SRETSS/SREBOT
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: squad KPS now averages per-player KPS instead of summing all kills

Browse Source 
Previously sqKps = sumAllPlayerKills / games, inflating the value ~8x
since all 8 players' kills were summed before dividing by game count.
Now computed as the mean of each active player's individual kills/games.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
deploy
2026-05-29 20:03:25 +00:00
parent 14430d3850
commit 8396f48f90
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server.js
+4 -1
View File
@@ -4468,7 +4468,10 @@ app.get('/api/squadrons/:squadronname', (req, res) => {
const sqCaptures = safeSummaryRow.total_captures || 0; const sqCaptures = safeSummaryRow.total_captures || 0;
const sqKdr = sqDeaths > 0 ? (sqTotalKills / sqDeaths) : sqTotalKills; const sqKdr = sqDeaths > 0 ? (sqTotalKills / sqDeaths) : sqTotalKills;
const sqWinRate = sqBattles > 0 ? (sqWins / sqBattles) * 100 : 0; const sqWinRate = sqBattles > 0 ? (sqWins / sqBattles) * 100 : 0;
const sqKps = sqBattles > 0 ? parseFloat((sqTotalKills / sqBattles).toFixed(2)) : 0; const activePlayers = players.filter(p => p.total_battles > 0);
const sqKps = activePlayers.length > 0
? parseFloat((activePlayers.reduce((sum, p) => sum + p.kps, 0) / activePlayers.length).toFixed(2))
: 0;
loadPerformanceBenchmarksCached(dateFilters, (benchmarks) => { loadPerformanceBenchmarksCached(dateFilters, (benchmarks) => {
const playerBenchmark = benchmarks.players; const playerBenchmark = benchmarks.players;
const squadronBenchmark = benchmarks.squadrons; const squadronBenchmark = benchmarks.squadrons;