Restore the dependency-change guard that got overwritten on main, and harden
the deploy + worker shutdown so a flaky better-sqlite3 rebuild can no longer
take the site down.
Root cause of the recurring outages: tssbot-web is the only stack with a
native module (better-sqlite3) that must be downloaded/compiled on every
`npm ci`. The deploy ran `npm ci` unconditionally (the skip guard had been
reverted), with no timeout, and `npm ci` deletes node_modules first -- so a
single hung/failed native rebuild left the site unstartable, and a PM2
cluster restart on top wedged the daemon.
webhook.cjs:
- Restore the npm-ci skip guard: only reinstall when package.json /
package-lock.json actually changed (previousHead captured before the pull),
so code-only pushes never rebuild better-sqlite3. Defaults to installing on
any uncertainty, and still installs if node_modules is incomplete.
- Add per-step timeouts to run() (DEPLOY_STEP_TIMEOUT_MS, and a tighter
DEPLOY_INSTALL_TIMEOUT_MS for npm ci) so a stalled step is killed instead of
hanging for hours with node_modules already deleted.
- Gate the deploy on better-sqlite3 actually loading (child-process load, not
just require.resolve): force a reinstall when its native binary is missing,
and abort before pm2 reload if it is still broken after install.
server.cjs:
- On shutdown, closeIdleConnections() + delayed closeAllConnections() so a
worker stop/reload can't hang the full kill_timeout on idle keep-alives or a
stuck upstream request.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Spectra sends kills with uppercase roman numerals (V/VI) but player
lineup CDKs use lowercase (v/vi). Normalize to lowercase in
deadVehicleKey, logVehicle, and logLookups so dead-vehicle fading
works on the website event log.
Deploys ran `npm ci` unconditionally, which wipes node_modules and
rebuilds native modules (better-sqlite3) on every push — ~20 min even
for a frontend-only change with no dependency changes.
Gate the clean install on package.json / package-lock.json actually
changing between the pre-pull HEAD and the new HEAD. As a safety net,
still install whenever the build's required modules (@vitejs/plugin-react,
@rollup/rollup-linux-x64-*) are missing from node_modules, so a skipped
install can never leave an incomplete tree. Frontend-only deploys now
skip straight to the build.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
deploy-migration
notsotoothless
clippii